Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snowflake sort tests #11905

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Fix snowflake sort tests #11905

merged 4 commits into from
Dec 20, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Dec 18, 2024

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 18, 2024
@AdRiley AdRiley force-pushed the wip/adr/fix-snowflake-sort-tests branch from b60bd89 to 340aa15 Compare December 20, 2024 08:39
@AdRiley AdRiley merged commit e5a1c5a into develop Dec 20, 2024
43 of 45 checks passed
@AdRiley AdRiley deleted the wip/adr/fix-snowflake-sort-tests branch December 20, 2024 13:48
Frizi pushed a commit that referenced this pull request Dec 30, 2024
@AdRiley @Frizi
Fix snowflake sort tests (#11905)
92eea32 
* Fix snowflake tests

* Rename flag to make code clearer

* Add new sort dialect flags

* Fix path for Snowflake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdRiley @radeusgd @jdunkerley @GregoryTravis